-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate new improvements from upstream in the React UI #3541
Comments
can you assign this issue to me @prmsrswt |
@subhangi2731 There are a lot of small tasks here, so you can pick something you'd like to work on and just comment here that you are working on it. That'll be sufficient to reduce duplicate efforts imo. |
@prmsrswt I'll open a PR for |
@prmsrswt I will work on the issue |
I will open a PR for |
This was closed by accident. Reopen it now. |
We also want to add the new editor. Should we add it here or open another issue? |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
still valid |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
In past few months there have been a sizable amount of UI related improvemnts in the upstream Prometheus code. A lot of those improvements make sense for Thanos as well.
Here's a list of PRs (in no specific order) that I think we should take a look at:
Fix styling bug for target labels with special names. Fix styling bug for target labels with special names prometheus/prometheus#7902Fixed in UI: Fix styling bug for target labels with special names #3692pathPrefix
in the React UI. react updates for pathPrefix prometheus/prometheus#7979Add key to StatusWithStatusIndicator component in loop. add key to StatusWithStatusIndicator component in loop prometheus/prometheus#6879Fixed in ui: Add key to StatusWithStatusIndicator #3656Fix react UI bug with series going on and off. Fix react UI bug with series going on and off prometheus/prometheus#7804Fixed in UI: Fix react UI bug with series going on and off #3693Fix detail swatch glitch. Fix detail swatch glitch prometheus/prometheus#7805Fixed in Fix detail swatch glitch #3676Fix button display when there is no panels. Fix button display when there is no panels prometheus/prometheus#8155Fixed in Fix button display when there is no panels #3694React UI: Change "metrics autocomplete" with "autocomplete". React UI: Change "metrics autocomplete" with "autocomplete" prometheus/prometheus#8174Fixed in Changed "metrics autocomplete" with "autocomplete" #3575Most of these are pretty straightforward and small changes and should be easy for first time contributors.
The text was updated successfully, but these errors were encountered: