UI: Fix styling bug for target labels with special names #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onprem
previously approved these changes
Jan 21, 2021
|
@Namanl2001 If you could rebase it we can merge this PR. |
bwplotka
previously approved these changes
Apr 1, 2021
Signed-off-by: Namanl2001 <[email protected]>
Signed-off-by: Namanl2001 <[email protected]>
auto-merge was automatically disabled
April 3, 2021 15:26
Head branch was pushed to by a user without write access
Namanl2001
force-pushed
the
fix-target-label-styling
branch
from
3369415
to
0b1d10b
Compare
Signed-off-by: Namanl2001 <[email protected]>
|
Resolved the conflicts. The failing test seems unrelated. |
onprem
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Namanl2001 [email protected]
Fixes a subissue
Fix styling bug for target labels with special names.in #3541