ui: Fix Block Viewer for Compactor and Store #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prem Kumar <[email protected]>
Signed-off-by: Prem Kumar <[email protected]>
Signed-off-by: Prem Kumar <[email protected]>
bwplotka
approved these changes
Aug 28, 2020
| @@ -14,6 +14,7 @@ We use *breaking :warning:* word for marking changes that are not backward compa | |||
| ### Fixed | |||
|
|
|||
| * [#3095](https://github.com/thanos-io/thanos/pull/3095) Rule: update manager when all rule files are removed. | |||
| * [#3098](https://github.com/thanos-io/thanos/pull/3098) ui: Fix Block Viewer for Compactor and Store | |||
There was a problem hiding this comment.
No need for this, as it's fixing the release directly. But that's ok I will adjust it.
| if viewParam == "loaded" { | ||
| return bapi.loadedBlocksInfo, nil, nil | ||
| } | ||
| return bapi.globalBlocksInfo, nil, nil |
There was a problem hiding this comment.
This feels weird from perspective on components that does not have global 🤔
Also I think it's on purpose that in code we talk about global view and in React / UI we have blocks?
There was a problem hiding this comment.
I agree it is weird. But in our last 1:1, me, @squat, and @GiedriusS discussed and decided to go with this. As we have the same API but different needs in different components (Bucket viewer: a global view of blocks, Compactor: both global and loaded and Store: loaded only) we came up with two solutions:
- Modify the API logic so that we can register a single type of API multiple times in a single component with different prefixes. This means that in the Compactor, we can create two instances of Blocks API on two different prefixes (let's say
/api/v1/loadedand/api/v1/global) much like how we handled the old UI. - Extend the blocks API to have two types of data (for Global and Loaded) always and add a query parameter in the existing
/api/v1/blocksendpoint.
The first solution is more generic but it requires us to modify logic for all of the API packages. Also, it would result in some weird endpoints like /api/v1/loaded/blocks and /api/v1/global/blocks (ideally the level of specificity should increase, /api/v1/blocks/loaded) because we can only add a prefix to a router. The second solution was simpler to implement and only affected the Blocks API. So even though it felt a little weird, we decided to go with it.
kakkoyun
pushed a commit
to kakkoyun/thanos
that referenced
this pull request
Sep 7, 2020
* ui: Fix Block viewer for Compactor and Store Signed-off-by: Prem Kumar <[email protected]> * Add an entry in CHANGELOG.md Signed-off-by: Prem Kumar <[email protected]> * ui: react: Fixed tests for Blocks Signed-off-by: Prem Kumar <[email protected]>
kakkoyun
pushed a commit
to kakkoyun/thanos
that referenced
this pull request
Sep 7, 2020
* ui: Fix Block viewer for Compactor and Store Signed-off-by: Prem Kumar <[email protected]> * Add an entry in CHANGELOG.md Signed-off-by: Prem Kumar <[email protected]> * ui: react: Fixed tests for Blocks Signed-off-by: Prem Kumar <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
added a commit
that referenced
this pull request
Sep 7, 2020
* Made sure old sse S3 option if specified, produces error. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Cut v0.15.0-rc.0 Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * tsdbstore: Optimized response framing if iterator finished. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Apply suggestions from code review Co-authored-by: Krasimir Georgiev <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Rule: update manager when all rule files are removed (#3095) This bug was already fixed in #2615 but it got lost when we merged #2200. Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Simon Pasquier <[email protected]> Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * ui: Fix Block Viewer for Compactor and Store (#3098) * ui: Fix Block viewer for Compactor and Store Signed-off-by: Prem Kumar <[email protected]> * Add an entry in CHANGELOG.md Signed-off-by: Prem Kumar <[email protected]> * ui: react: Fixed tests for Blocks Signed-off-by: Prem Kumar <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * querier: Fix overwriting maxSourceResolution when auto downsampling is enabled (#3105) * Fix overwriting maxSourceResolution when auto downsampling is enabled Signed-off-by: Ben Ye <[email protected]> * add changelog Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Author: Krasi Georgiev <[email protected]> Date: Thu Aug 27 14:10:19 2020 +0300 (#3010) Make the PromQL lookBack configurable with a flag Signed-off-by: Krasi Georgiev <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Cut release v0.15.0-rc.1 (#3103) * Cut release v0.15.0-rc.1 Signed-off-by: Kemal Akkoyun <[email protected]> * Address review issues Signed-off-by: Kemal Akkoyun <[email protected]> * Fix changelog Signed-off-by: Kemal Akkoyun <[email protected]> * Cut release v0.15.0 (#3129) Signed-off-by: Kemal Akkoyun <[email protected]> * Minor fix Signed-off-by: Kemal Akkoyun <[email protected]> * Address review comments Signed-off-by: Kemal Akkoyun <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Krasimir Georgiev <[email protected]> Co-authored-by: Simon Pasquier <[email protected]> Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Co-authored-by: Prem Kumar <[email protected]> Co-authored-by: Ben Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prem Kumar [email protected]
Fixes #3093
Changes
Verification
Tested locally for Bucket web, Compactor, and Store using docker-compose setup.