Rule: update manager when all rule files are removed #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was already fixed in thanos-io#2615 but it got lost when we merged thanos-io#2200. Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
fix-empty-rules-reload
branch
from
23b77c3
to
7535187
Compare
|
cc @bwplotka since you've cut the first RC of v0.15.0 and I submit the PR against the |
bwplotka
approved these changes
Aug 28, 2020
| @@ -11,6 +11,10 @@ We use *breaking :warning:* word for marking changes that are not backward compa | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| * [#3095](https://github.com/thanos-io/thanos/pull/3095) Rule: update manager when all rule files are removed. | |||
There was a problem hiding this comment.
It's not a proper place, but that's fine I will fix.
|
Will do Rc1 once we have #3093 fixed cc @prmsrswt |
kakkoyun
pushed a commit
to kakkoyun/thanos
that referenced
this pull request
Sep 7, 2020
This bug was already fixed in thanos-io#2615 but it got lost when we merged thanos-io#2200. Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Simon Pasquier <[email protected]> Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]>
kakkoyun
pushed a commit
to kakkoyun/thanos
that referenced
this pull request
Sep 7, 2020
This bug was already fixed in thanos-io#2615 but it got lost when we merged thanos-io#2200. Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Simon Pasquier <[email protected]> Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
added a commit
that referenced
this pull request
Sep 7, 2020
* Made sure old sse S3 option if specified, produces error. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Cut v0.15.0-rc.0 Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * tsdbstore: Optimized response framing if iterator finished. Signed-off-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Apply suggestions from code review Co-authored-by: Krasimir Georgiev <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Rule: update manager when all rule files are removed (#3095) This bug was already fixed in #2615 but it got lost when we merged #2200. Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Simon Pasquier <[email protected]> Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * ui: Fix Block Viewer for Compactor and Store (#3098) * ui: Fix Block viewer for Compactor and Store Signed-off-by: Prem Kumar <[email protected]> * Add an entry in CHANGELOG.md Signed-off-by: Prem Kumar <[email protected]> * ui: react: Fixed tests for Blocks Signed-off-by: Prem Kumar <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * querier: Fix overwriting maxSourceResolution when auto downsampling is enabled (#3105) * Fix overwriting maxSourceResolution when auto downsampling is enabled Signed-off-by: Ben Ye <[email protected]> * add changelog Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Author: Krasi Georgiev <[email protected]> Date: Thu Aug 27 14:10:19 2020 +0300 (#3010) Make the PromQL lookBack configurable with a flag Signed-off-by: Krasi Georgiev <[email protected]> Signed-off-by: Kemal Akkoyun <[email protected]> * Cut release v0.15.0-rc.1 (#3103) * Cut release v0.15.0-rc.1 Signed-off-by: Kemal Akkoyun <[email protected]> * Address review issues Signed-off-by: Kemal Akkoyun <[email protected]> * Fix changelog Signed-off-by: Kemal Akkoyun <[email protected]> * Cut release v0.15.0 (#3129) Signed-off-by: Kemal Akkoyun <[email protected]> * Minor fix Signed-off-by: Kemal Akkoyun <[email protected]> * Address review comments Signed-off-by: Kemal Akkoyun <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Krasimir Georgiev <[email protected]> Co-authored-by: Simon Pasquier <[email protected]> Co-authored-by: johncming <[email protected]> Co-authored-by: Lili Cosic <[email protected]> Co-authored-by: Prem Kumar <[email protected]> Co-authored-by: Ben Ye <[email protected]>
This was referenced Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This bug was already fixed in #2615 but it got lost when we merged #2200.
Verification
A unit test has been added.