-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation and CHANGELOG.md entry for #2579. #2618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Just DCO & LGTM!
🤦 |
Signed-off-by: Peter Štibraný <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pstibrany One thing I have realized, we mentioned and documented config file to use it, however the flag itself is not documented and it is hidden (if it hasn't changed). This might create confusion. Should we also make it visible or at least mention it somewhere?
That's a good point. I will put it into documentation and changelog entry. |
…idden. Signed-off-by: Peter Štibraný <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
docs/components/store.md
Outdated
``` | ||
|
||
`backend_config` field for memcached supports all the same configuration as memcached for [index cache](#memcached-index-cache). | ||
|
||
`caching_config` is a configuration for chunks cache and supports the following optional settings: | ||
`caching_config` is a configuration for cache and supports the following optional settings for chunks caching: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But caching_config
key doesn't exist, right? 🤔 It has been moved a level up. So, I think this line should be reworded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct. I've removed mention of caching_config
.
Signed-off-by: Peter Štibraný <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just left a nit)
Signed-off-by: Peter Štibraný <[email protected]>
This PR adds CHANGELOG entry and documentation for PR #2579.