Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Add mixin to enable caching bucket #122

Merged
merged 9 commits into from
May 20, 2020

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented May 15, 2020

This PR adds a mixin to enable caching bucket support.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Add withCachingBucketMemcached for Thanos Store to enable caching bucket.
  • Rename withMemcachedIndexCache to withIndexCacheMemcached for consistency.
  • Bump version to the one include the feature.

Verification

  • make generate
  • Local test

@kakkoyun kakkoyun requested a review from metalmatze May 15, 2020 12:37
@kakkoyun kakkoyun marked this pull request as ready for review May 15, 2020 12:39
@kakkoyun
Copy link
Member Author

@pstibrany Could also have a look at it?

@kakkoyun kakkoyun requested review from bwplotka and brancz May 15, 2020 12:39
@pstibrany
Copy link

pstibrany commented May 15, 2020

After merging thanos-io/thanos#2579, config has changed slightly (config_cache field has been removed, and more options are available):

backend: memcached
backend_config:
  addresses:
    - localhost:11211

chunk_subrange_size: 16000
max_chunks_get_range_requests: 3
chunk_object_size_ttl: 24h
chunk_subrange_ttl: 24h
blocks_iter_ttl: 5m
metafile_exists_ttl: 2h
metafile_doesnt_exist_ttl: 15m
metafile_content_ttl: 24h
metafile_max_size: 1MiB

Since that PR was merged without documentation change and CHANGELOG entry, I'm sending new PR shortly (working on it).

Update: thanos-io/thanos#2618

@kakkoyun kakkoyun marked this pull request as draft May 15, 2020 17:02
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun kakkoyun marked this pull request as ready for review May 18, 2020 08:29
@pstibrany
Copy link

pstibrany commented May 18, 2020

Heads up: another change incoming in PR thanos-io/thanos#2613 (chunk_object_size_ttl -> chunk_object_attrs_ttl)

@kakkoyun kakkoyun marked this pull request as draft May 18, 2020 13:07
@kakkoyun
Copy link
Member Author

Marking it as WIP until Thanos v0.13 released, since upcoming release may include related changes.

@kakkoyun kakkoyun marked this pull request as ready for review May 20, 2020 08:26
@kakkoyun
Copy link
Member Author

Thanos v0.13.0-rc.0 released, we can proceed with this https://github.com/thanos-io/thanos/releases/tag/v0.13.0-rc.0

@brancz brancz merged commit ad6e086 into thanos-io:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants