Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register thanos_alert_sender_errors_total metric. #2101

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Register thanos_alert_sender_errors_total metric. #2101

merged 2 commits into from
Feb 5, 2020

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Feb 5, 2020 •
edited
Loading

#2100
Fixes #2100

Signed-off-by: Kevin Hellemun [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@OGKevin OGKevin marked this pull request as ready for review February 5, 2020 13:17
yeya24
yeya24 approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwplotka bwplotka merged commit 57a1eae into thanos-io:master Feb 5, 2020
@OGKevin OGKevin deleted the register_err_metric_2100 branch February 5, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruler: register sender errors (thanos_alert_sender_errors_total) metric.
3 participants
@OGKevin @bwplotka @yeya24