We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thanos, Prometheus and Golang version used: Thanos: https://github.com/thanos-io/thanos/releases/tag/v0.10.1
Object Storage Provider:
What happened: There is a bug in the code here:
thanos/pkg/alert/alert.go
Lines 290 to 318 in 7c02430
The errors metric is not registered in the registry. This means that this metric is missing and therefore not exposed.
What you expected to happen: This metric to exist.
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components:
Anything else we need to know:
The text was updated successfully, but these errors were encountered:
Register thanos_alert_sender_errors_total metric.
893be12
thanos-io#2100 Fixes thanos-io#2100 Signed-off-by: Kevin Hellemun <[email protected]>
Ups!
Sorry, something went wrong.
Register thanos_alert_sender_errors_total metric. (#2101)
57a1eae
* Register thanos_alert_sender_errors_total metric. #2100 Fixes #2100 Signed-off-by: Kevin Hellemun <[email protected]> * Updated CHANGELOG. Signed-off-by: Kevin Hellemun <[email protected]>
Ok it's enough, we have too many of such issues. Let's automate this and add some test: #2102
Successfully merging a pull request may close this issue.
Thanos, Prometheus and Golang version used:
Thanos: https://github.com/thanos-io/thanos/releases/tag/v0.10.1
Object Storage Provider:
What happened:
There is a bug in the code here:
thanos/pkg/alert/alert.go
Lines 290 to 318 in 7c02430
The errors metric is not registered in the registry. This means that this metric is missing and therefore not exposed.
What you expected to happen:
This metric to exist.
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components:
Anything else we need to know:
The text was updated successfully, but these errors were encountered: