Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _total suffix to two counter metrics #2021

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jan 21, 2020

Signed-off-by: yeya24 [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

I guess we need _total in counter metrics

Verification

Copy link
Member

@FUSAKLA FUSAKLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me, just better to put it to changelog, so we don't forget update the mixins once released maybe?

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is almost even mandatory to put change log AND change jsonnet in same PR so it won't get lost (:

Thanks for doing this, you are amazing @yeya24
We are having some conference week but we should be more active in reviewing next week, sorry for delays!

@yeya24
Copy link
Contributor Author

yeya24 commented Jan 23, 2020

Sure. I will add the changelog. But I didn't find any related rules in the mixin. And couldn't find that in the kube-thanos repo as well

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no alert/rule/dashboard related then it's fine 👍

@bwplotka bwplotka merged commit bb48830 into thanos-io:master Jan 23, 2020
@yeya24 yeya24 deleted the rename-counter branch January 23, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants