add _total suffix to counter metrics

Signed-off-by: yeya24 <[email protected]>

CHANGELOG.md

@@ -27,6 +27,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
 ### Changed
 
 - [#1933](https://github.com/thanos-io/thanos/pull/1933) Add a flag `--tsdb.wal-compression` to configure whether to enable tsdb wal compression in ruler and receiver.
+- [#2021](https://github.com/thanos-io/thanos/pull/2021) Rename metric `thanos_query_duplicated_store_address` to `thanos_query_duplicated_store_addresses_total` and `thanos_rule_duplicated_query_address` to `thanos_rule_duplicated_query_addresses_total`.
 
 ## [v0.10.0](https://github.com/thanos-io/thanos/releases/tag/v0.10.0) - 2020.01.13
 

cmd/thanos/query.go

@@ -201,7 +201,7 @@ func runQuery(
 ) error {
 	// TODO(bplotka in PR #513 review): Move arguments into struct.
 	duplicatedStores := prometheus.NewCounter(prometheus.CounterOpts{
-		Name: "thanos_query_duplicated_store_address",
+		Name: "thanos_query_duplicated_store_addresses_total",
 		Help: "The number of times a duplicated store addresses is detected from the different configs in query",
 	})
 	reg.MustRegister(duplicatedStores)

cmd/thanos/rule.go

@@ -246,7 +246,7 @@ func runRule(
 		Help: "Timestamp of the last successful configuration reload.",
 	})
 	duplicatedQuery := prometheus.NewCounter(prometheus.CounterOpts{
-		Name: "thanos_rule_duplicated_query_address",
+		Name: "thanos_rule_duplicated_query_addresses_total",
 		Help: "The number of times a duplicated query addresses is detected from the different configs in rule",
 	})
 	rulesLoaded := prometheus.NewGaugeVec(