support build docker images for arm64 arch

[daixiang0]

Signed-off-by: Xiang Dai [email protected]

• I added CHANGELOG entry for this change.

Changes

Fix #1851

[daixiang0]

I have no permission to test push related things, build pass at local.

[daixiang0]

Prometheus also support arm, but i saw corss build only generate binary for amd64 and arm64, so do not add it.

[bwplotka]

Thanks a lot!

But I think we can simplify here a lot. Let's instead use the way Prometheus is doing this, so https://github.com/prometheus/prometheus/blob/337a1fbffd17ad3c7952dadf1246ee6eedf57b01/Makefile.common#L213

And dockerfile taking from promu (we already use promu for the build process):
https://github.com/prometheus/prometheus/blob/bca6e90ea6788100a56809e73f9eeaaa11480036/Dockerfile#L6

What do you think? (:

[daixiang0]

@bwplotka I use the way Prometheus does, please review again.

[simonpasquier]

A few things from my Prometheus experience:

• someone with permissions needs to create in advance the following repositories on quay.io.
  • quay.io/thanos/thanos-linux-amd64
  • quay.io/thanos/thanos-linux-arm64
• you need to add a step running docker run --privileged linuxkit/binfmt:v0.7 (see here).
• you might need to upgrade the Docker version to 18.06.0-ce.

And there might other things that I don't remember ;-)

[daixiang0]

@simonpasquier yep, but i have no premissions to test while process:(

[bwplotka]

I like it, but indeed only the maintainer can test it and I will do this in free time.

Thanks for nice tips @simonpasquier !

Also make build with promu build just ./thanos so make build and building docker will not work anymore... This was a nice manual flow that some dev uses. I think this is fine though, we adjust it in local dev script.

[daixiang0]

@bwplotka wait for your feedback~

[daixiang0]

@bwplotka do you have time to test it?

[simonpasquier]

This looks good to me. The only real way to be sure it works would be to merge and see what happens :-)

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

[daixiang0]

@bwplotka hi, do you have time to test it?

[bwplotka]

Yea not really. Will speak offline how we can move this forward (:

…

On Sat, 21 Mar 2020 at 09:59, Xiang Dai ***@***.***> wrote: @bwplotka <https://github.com/bwplotka> hi, do you have time to test it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1906 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVA3O5LBKJGYGVO4YLRDNTRISFZNANCNFSM4J4HBSTQ> .

[povilasv]

Hey, I'm interested in this and I think I will be able to help, ping me on monday :)

[daixiang0]

@povilasv thanks!

[povilasv]

So right github actions for e2e are failing and are not flaky, we need to fix this.

The issue is believe that build step produces binaries not in .build/${OS}-${ARCH}/thanos :

build: check-git deps $(PROMU)
	@echo ">> building binaries $(GOBIN)"	
	@$(PROMU) build --prefix $(PREFIX)

I suggest trying to change that to:

build: check-git deps $(PROMU)
	@echo ">> building binaries $(GOBIN)"	
	@$(PROMU) crossbuild --prefix $(PREFIX) -p 'linux/amd64'

I think this should put the binary into correct dir.

[daixiang0]

The CI test result show that we can not use --prefix for promu crossbuild:

>> building binaries /go/bin
promu-9583e5a6448f97c6294dca72dd1d173e28f8d4a4: error: unknown long flag '--prefix', try --help
##[error]make: *** [Makefile:153: build] Error 1

Just change "linux" to "$OS" is enough.

[daixiang0]

@GiedriusS @hanjm Please review again.

[GiedriusS]

💪 hope this works

[GiedriusS]

Had to use a different emulator to make it work: 9faf940. Now thanos:latest cannot be found, working on it.