Upload container images for arm64 architecture

[der-eismann]

Now that AWS announced their way more powerful M6g instances it will start to get interesting to move from x86 to the ARM architecture. You already provide binaries on the releases page, but the docker images are for x86 only. Could you maybe adjust your build pipeline and provide images for ARM like prometheus does?

[bwplotka]

We can definitely consider this (:

Help wanted to set it up.

[der-eismann]

I'd be happy to help, but unfortunately it seems like CircleCI doesn't support it (yet). There are some hacky workarounds, but I'm not sure if this is the correct way.

So actually I have no idea how to do this right now.

[bwplotka]

I don't think we need any CI special feature for this:

Let's instead use the way Prometheus is doing this, so:
Docker build:

• https://github.com/prometheus/prometheus/blob/337a1fbffd17ad3c7952dadf1246ee6eedf57b01/Makefile.common#L213

And Dockerfile taking binaries from promu (we already use promu for the build process):

• https://github.com/prometheus/prometheus/blob/bca6e90ea6788100a56809e73f9eeaaa11480036/Dockerfile#L6

(:

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bwplotka]

Still valid, and in fact we have a PR ready - it's waiting on us to actually test it and update quay a bit.

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

[zosorock]

I am also looking into starting to test with m6g instances. Are there any prediction of when it will be available?

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[autarchprinceps]

Is this still being worked on? I just tested and the thanos-sidecar in Prometheus is one of only a few containers that still make issues.

[bwplotka]

We had contributions to add the build/CI process. but I think there is some process of configuration on quay/dockerhub. To test and finish up.

cc @daixiang0

[daixiang0]

While I have no permission to test it, please help @bwplotka !

[commixon]

Hello people! Is this still a valid thing? We would really like this as well (and are willing to help with anything as well)

[bwplotka]

Looks like it's getting quite a popular feature (: We already build such binaries - so you can easily build (make crossbuild) and upload to your own registry. Ideally we have someone who can configure docker registry for us 🙃 which is unlikely. For some reasons @daixiang0 had issues to access things from China I believe.

We will try to prioritize this on maintainer team (: Thanks!

[der-eismann]

FYI this is how we did it with GitHub actions, works fine for us so far:
https://github.com/rebuy-de/aws-nuke/blob/main/.github/workflows/release.yaml#L48-L78
Basically you need QEMU & buildx for docker, then it's possible to build for all arches.

[roidelapluie]

I don't think thanos requires this, it could use standard go crossbuild. I am happy to see how we can share promu with thanos, but generic tools like goreleaser would work too.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[der-eismann]

Still needed.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[autarchprinceps]

Still needed.

[der-eismann]

Remove the stale label please

[hanzZzZzZ]

Just found this issue, but I can confirm:
Still needed.

[ismashal]

We really needed this ARM64 supported official image into the docker hub and quay.io/thanos/thanos. As AWS already started the support graviton2 type images into the EKS.
Thanks!

[avivgold098]

We will be very helpful:
Still needed. :)

[WeiTangLau]

2 years later. Still needed

[firefixmaarten]

Still wanted :) +1, in my case armv7.

[GiedriusS]

After #4947 is done, we will finally have this ready. @firefixmaarten could you please open a separate ticket for armv7?

[GiedriusS]

https://quay.io/repository/thanos/thanos/manifest/sha256:ba0b9192a0db3693afcb220c4c1fc8578a1c25df20dc41697e57b3329fe1d7f8
https://hub.docker.com/layers/thanosio/thanos/main-2021-12-14-7793ab63/images/sha256-9dd0cee98ac7dc4f122e75d4fade9ba2452e8a9a2c0b8cb9a160e55ce1bae0f1?context=explore
We finally have arm64 images as well 🎉 everything should be transparent to the users. Please test them out.

[WeiTangLau]

Hi @GiedriusS, given the latest release of v0.24.0 and v0.23.2 of thanos, the arm64 images are not built accordingly. Why is this so?

https://hub.docker.com/layers/thanosio/thanos/v0.24.0/images/sha256-b8f527c6750d76c2bd637c7047e95bfc3b4e42a2be454b2efef00cc3d9a55a15?context=explore

https://hub.docker.com/layers/thanosio/thanos/v0.23.2/images/sha256-1936fe5c5829756d5c94af8c9a497ae7f4ce107e7ff5c4876cb26016aa857cd3?context=explore

[jan-di]

@WeiTangLau Not a maintainer here, but i guess thats because the release candidates of those versions pre date the merge of this feature. See https://github.com/thanos-io/thanos/commits/v0.24.0. I think the next release (0.25) will have arm64 images.