Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Gun Sound Overhaul #5261

Merged
merged 10 commits into from
Nov 23, 2020
Merged

Conversation

XSlayer300
Copy link
Contributor

@XSlayer300 XSlayer300 commented Nov 15, 2020

About The Pull Request

Reoverhauls almost every gun sound in the game, replacing every sound that was from CM or making the sounds from other games less noticeable. This also adds unique sounds to the dropship weapons, as well replacing the empty gun sound with a new one.

All sounds are from (if I remember correctly):

  • Call of Duty series

  • Halo series

  • Insurgency

  • Counter Strike: Global Offensive

  • Team Fortress 2

  • Ghost in the Shell Stand Alone Complex - First Assault Online

  • Fallout series

  • And others that I forgot.

  • Along with some of the original CM sounds.

All (new) sounds are from their respective owners, and I (and the entire community) do not take ownership from these sounds, mixed or not. They use the CC-BY-NC-SA 3.0/Creative Commons Attribution-NonCommercial-ShareAlike 3.0 United States license.

If any IP wants me to remove those sounds mixed in with the original ones, I would be glad to oblige.

Why It's Good For The Game

Because for me, I'm getting sort of tired hearing CM sounds in TGMC, so we're bringing something unique.

Changelog

🆑
tweak: Completely OVERHAULS almost all of the useable weapons, adding new ones...
del: ... and removing unused sounds or sounds from the leaked CM codebase.
tweak: All sounds now have consistent volume. Not all weapon sounds are changed.
tweak: The gunship's weapons now use a unique sound when firing
tweak: Changed the empty reloading sound.
tweak: Changed the *salute emote.
tweak: If you like/love the sounds, great. But if you don't like it, I respect your opinion.
tweak: All sounds use the CC-BY-NC-SA 3.0/Creative Commons Attribution-NonCommercial-ShareAlike 3.0 United States license. See PR for list of sounds used.
tweak: Fixed minor typos.
/:cl:

@tgstation-server tgstation-server added Removal Feature removal due to maintainibility or design direction. Sound Sound change. Tweak labels Nov 15, 2020
@XSlayer300
Copy link
Contributor Author

Switched current license to CC-BY-NC-SA 3.0/Creative Commons Attribution-NonCommercial-ShareAlike 3.0 United States

@XSlayer300 XSlayer300 changed the title Gun sounds reoverhaul The Gun Sound Overhaul Nov 16, 2020
@XSlayer300
Copy link
Contributor Author

Awaiting review...

Copy link
Member

@TiviPlus TiviPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fuck it its good enough

@TiviPlus TiviPlus added Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. and removed Removal Feature removal due to maintainibility or design direction. labels Nov 20, 2020
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 20, 2020
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 20, 2020
code/game/objects/machinery/smartgun_mount.dm Outdated Show resolved Hide resolved
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 21, 2020
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 21, 2020
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 22, 2020
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 22, 2020
@Hughgent Hughgent merged commit 85468d6 into tgstation:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sound Sound change. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants