-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS order announcements/hivemind #16662
Open
TiviPlus
wants to merge
6
commits into
tgstation:master
Choose a base branch
from
TiviPlus:ttsannouncements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Feature
New interesting mechanics with new interesting bugs
label
Oct 12, 2024
Lumipharon
approved these changes
Oct 14, 2024
Lumipharon
added
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Oct 14, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 14, 2024
Lumipharon
requested changes
Oct 14, 2024
code/datums/jobs/squads.dm
Outdated
var/list/extra_filters = list(TTS_FILTER_RADIO) | ||
if(isrobot(sender)) | ||
extra_filters += TTS_FILTER_SILICON | ||
INVOKE_ASYNC(SStts, TYPE_PROC_REF(/datum/controller/subsystem/tts, queue_tts_message), marines_list, treated_message["tts_message"], sender.get_default_language(), sender.voice, sender.voice_filter, local = TRUE, pitch = sender.pitch, special_filters = extra_filters.Join("|"), directionality = FALSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marines_list should be the listeners arg, first arg is 'target' which seems to be the actual speaker. Same with the xeno annoucements
Lumipharon
reviewed
Oct 14, 2024
Co-authored-by: Lumipharon <[email protected]>
tgstation-server
removed
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Oct 15, 2024
TiviPlus
added
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Oct 15, 2024
Lumipharon
reviewed
Oct 15, 2024
tgstation-server
removed
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Oct 15, 2024
Lumipharon
added
the
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
label
Oct 15, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 15, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 16, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 16, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 17, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 17, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 17, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 17, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 18, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 19, 2024
comfyorange
added a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
New interesting mechanics with new interesting bugs
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
As the title says orders and xeno hivemind now use tts
TM because local testing doesnt exist
Why It's Good For The Game
Orders because its orders so nice to add more emphasis, hivemind because its the major comms venue for xenos
Changelog
🆑
add: hivemind now uses tts
add: orders now use tts
/:cl: