forked from NVIDIA/spark-rapids
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor
cudf::contains
(NVIDIA#10997)
This is just a simple refactor to `cudf::contains`: * Remove `cudf/structs/detail/contains.hpp` and its corrresponding source file `src/structs/search/contains.cu`, moving its (modified) implementation into `src/search/contains_nested.cu`. * Adopt `experimental::row::equality::two_table_comparator` for struct equality comparison. * Add `const` qualifier for the `operator()` functions. * Rename some variables, and reorganize code to make it cleaner. No new feature is added in this PR, just modifying the existing functions and moving things around. This PR is extracted from the bigger PR for easier review. The original PR is rapidsai/cudf#10656 for fully supporting nested type in `cudf::contains`. As such, this blocks it. Authors: - Nghia Truong (https://github.com/ttnghia) - Devavret Makkar (https://github.com/devavret) - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Jordan Jacobelli (https://github.com/Ethyling) - Robert Maynard (https://github.com/robertmaynard) - Yunsong Wang (https://github.com/PointKernel) URL: rapidsai/cudf#10997
- Loading branch information
Showing
9 changed files
with
185 additions
and
228 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.