Refactor cudf::contains
#10997
Merged
Refactor cudf::contains
#10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve doc of decompose structs to account for lists
- avoid copying shared_ptrs for linked_col
Fixes the problem of having multiple copies of children
ttnghia
removed
the
improvement
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
improvement
davidwendt
requested changes
May 27, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
|
Rerun tests. |
PointKernel
reviewed
May 30, 2022
Signed-off-by: Nghia Truong <[email protected]>
davidwendt
reviewed
May 31, 2022
davidwendt
approved these changes
May 31, 2022
Co-authored-by: David Wendt <[email protected]>
jjacobelli
approved these changes
May 31, 2022
robertmaynard
approved these changes
May 31, 2022
PointKernel
approved these changes
May 31, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
This extends the `cudf::contains` API to support nested types (lists + structs) with arbitrarily nested levels. As such, `cudf::contains` will work with literally any type of input data. In addition, this fixes null handling of `cudf::contains` with structs column + struct scalar input when the structs column contains null rows at the top level while the scalar key is valid but all nulls at children levels. Closes: #8965 Depends on: * #10730 * #10883 * #10802 * #10997 * NVIDIA/cuCollections#172 * NVIDIA/cuCollections#173 * #11037 * #11356 Authors: - Nghia Truong (https://github.com/ttnghia) - Devavret Makkar (https://github.com/devavret) - Bradley Dice (https://github.com/bdice) - Karthikeyan (https://github.com/karthikeyann) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Bradley Dice (https://github.com/bdice) - Yunsong Wang (https://github.com/PointKernel) URL: #10656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple refactor to
cudf::contains:cudf/structs/detail/contains.hppand its corrresponding source filesrc/structs/search/contains.cu, moving its (modified) implementation intosrc/search/contains_nested.cu.experimental::row::equality::two_table_comparatorfor struct equality comparison.constqualifier for theoperator()functions.No new feature is added in this PR, just modifying the existing functions and moving things around.
This PR is extracted from the bigger PR for easier review. The original PR is #10656 for fully supporting nested type in
cudf::contains. As such, this blocks it.