Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support contains with template key types #172

Closed
ttnghia opened this issue Jun 3, 2022 · 0 comments · Fixed by #174
Closed

[FEA] Support contains with template key types #172

ttnghia opened this issue Jun 3, 2022 · 0 comments · Fixed by #174
Labels
helps: rapids Helps or needed by RAPIDS P1: Should have Necessary but not critical topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap type: feature request New feature request

Comments

@ttnghia
Copy link

ttnghia commented Jun 3, 2022

Currently, the contains APIs of various maps (in particular, static_map and static_multimap) require that their input iterators must be dereferenced into the maps' key_type. As such, we cannot insert keys of one type and check the existence of keys from another (convertible) type.

We should support contains with template key types.
@PointKernel PointKernel added type: feature request New feature request helps: rapids Helps or needed by RAPIDS labels Jun 3, 2022
This was referenced Jun 3, 2022
Merged
Merged
@PointKernel PointKernel added topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap labels Jun 3, 2022
@PointKernel PointKernel mentioned this issue Jun 4, 2022
Merged
@PointKernel PointKernel added the P1: Should have Necessary but not critical label Jun 4, 2022
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Aug 17, 2022
@ttnghia
Fully support nested types in cudf::contains (#10656)
127d574 
This extends the `cudf::contains` API to support nested types (lists + structs) with arbitrarily nested levels. As such, `cudf::contains` will work with literally any type of input data.

In addition, this fixes null handling of `cudf::contains` with structs column + struct scalar input when the structs column contains null rows at the top level while the scalar key is valid but all nulls at children levels.

Closes: #8965
Depends on:
 * #10730
 * #10883
 * #10802
 * #10997
 * NVIDIA/cuCollections#172
 * NVIDIA/cuCollections#173
 * #11037
 * #11356

Authors:
  - Nghia Truong (https://github.com/ttnghia)
  - Devavret Makkar (https://github.com/devavret)
  - Bradley Dice (https://github.com/bdice)
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #10656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
helps: rapids Helps or needed by RAPIDS P1: Should have Necessary but not critical topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap type: feature request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make device contains take a template key parameter PointKernel/cuCollections
2 participants
@ttnghia @PointKernel