Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder function arguments #64

Closed
tginsberg opened this issue Dec 27, 2024 · 0 comments · Fixed by #72
Closed

Reorder function arguments #64

tginsberg opened this issue Dec 27, 2024 · 0 comments · Fixed by #72
Labels
enhancement New feature or request

Comments

@tginsberg
Copy link
Owner

The ...By(fn, someArg) argument order should be reversed so the function always comes last. This might make things nicer to work with from Kotlin, if for whatever reason people are using java streams there and not writing extension functions.

@tginsberg tginsberg added the enhancement New feature or request label Dec 27, 2024
tginsberg added a commit that referenced this issue Dec 27, 2024
+ More Kotlin friendly, if people end up using this from Kotlin instead of extension functions on Stream
+ More consistent, easier for me to remember the order
tginsberg added a commit that referenced this issue Dec 27, 2024
+ More Kotlin friendly, if people end up using this from Kotlin instead of extension functions on Stream
+ More consistent, easier for me to remember the order
This was referenced Jan 6, 2025
tginsberg added a commit that referenced this issue Jan 6, 2025
* Branch for v0.7.0

* JavaDoc fixes (#58)

* Fix #57: Use greedy integrators where possible (#59)

+ Greedy integrators can be used anywhere the integrator does not itself initiate a short circuit (returns false). Passing along the downstream rejecting flag is allowed for greedy integrators.

* Implement JSpecify nullability annotations (#60)

+ Implement JSpecify nullability annotations
+ Add ErrorProne and NullAway to build for compile-time checks
+ Add more tests to `MinMaxGatherer` as highlighted by coverage report

* Make nullable lists more sane, update JEP reference (#61)

* Implement ordering by frequency (#62)

* Implement movingSum, movingSumBy, movingProduct, and movingProductBy (#63)

* Misc Cleanups (#66)

+ Nullability annotations in Gatherers4j.java
+ Minimum windowSize is 1 in a lot of places, not zero.
+ Add constructor to GroupingByGatherer and handle null mapping function to make nullability checks happier
+ Parameterize tests where multiple independent assertions were taking place

* #64 - Change order of arguments so functions are last (#67)

+ More Kotlin friendly, if people end up using this from Kotlin instead of extension functions on Stream
+ More consistent, easier for me to remember the order

* Remove min/max (#68)

* Broader support for stream sizes (#69)

+ Rename `exactSize(n)` to `sizeExactly(n)`
+ Add `sizeGreaterThan(n)`
+ Add `sizeGreaterThanOrEqualTo(n)`
+ Add `sizeLessThan(n)`
+ Add `sizeLessThanOrEqualTo(n)`

* Misc fixes (#70)

* Use default implementation of checkFinalLength when tryAccept will fail-fast.

* Eliminate warning

* Release v0.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant