Holocene 1559 params for block building #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mininny
force-pushed
the
feature/mininny/holocene-1559-params
branch
from
77950b7
to
9cf8675
Compare
mininny
changed the base branch from
op-erigon
to
feature/mininny/holocene-hardfork
pcw109550
reviewed
Oct 14, 2024
consensus/misc/eip1559.go
Outdated
| @@ -101,18 +102,55 @@ func (f eip1559Calculator) CurrentFees(chainConfig *chain.Config, db kv.Getter) | |||
| return baseFee, blobFee, minBlobGasPrice, currentHeader.GasLimit, nil | |||
| } | |||
|
|
|||
| // CalcBaseFee calculates the basefee of the header. | |||
| // DecodeHolocene1599Params extracts the Holcene 1599 parameters from the encoded form: | |||
There was a problem hiding this comment.
Suggested change
| // DecodeHolocene1599Params extracts the Holcene 1599 parameters from the encoded form: | |
| // DecodeHolocene1559Params extracts the Holcene 1559 parameters from the encoded form: |
We need to fix 1599 to 1559 throughout the code.
There was a problem hiding this comment.
I fixed it throughout the whole code! :)
mininny
force-pushed
the
feature/mininny/holocene-1559-params
branch
from
099c714
to
7a151bb
Compare
pcw109550
approved these changes
Oct 15, 2024
…xecution-payload Holocene: Use ExtraData instead of Nonce for eip1559Params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes required to implement the configurable EIP-1559 parameters that are part of the Holocene upgrade.
Prerequisite erigon-interfaces PR: testinprod-io/erigon-interfaces#21
Spec: ethereum-optimism/specs#340
Mirrored from op-geth PR: ethereum-optimism/op-geth#398