Holocene: extensions for configurable EIP-1559 params #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
holocene-1559
branch
7 times, most recently
from
31f2e5f
to
2acd596
Compare
roberto-bayardo
changed the title
roberto-bayardo
force-pushed
the
holocene-1559
branch
5 times, most recently
from
6bd196c
to
45bf7f7
Compare
sebastianst
requested changes
Oct 9, 2024
clabby
reviewed
Oct 9, 2024
roberto-bayardo
force-pushed
the
holocene-1559
branch
3 times, most recently
from
63af417
to
856ad60
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
2 times, most recently
from
ee91931
to
a18fa18
Compare
sebastianst
approved these changes
Oct 9, 2024
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
a18fa18
to
2de32a5
Compare
clabby
approved these changes
Oct 9, 2024
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
2de32a5
to
de0864c
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
de0864c
to
fbce972
Compare
|
Cleaned up the tests a bit. |
tynes
reviewed
Oct 9, 2024
tynes
reviewed
Oct 9, 2024
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
fbce972
to
0dd2890
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
5 times, most recently
from
f29b20e
to
97c1ff0
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
97c1ff0
to
344422c
Compare
sebastianst
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the op-geth changes required to implement the configurable EIP-1559 parameters that are part of the Holocene upgrade.
Tests
Unit tests added for the new functionality and to exercise the various INVALID payload conditions in the spec.
Additional context
Metadata
ethereum-optimism/specs#340