Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/update nx and angular 13 #260

Merged

Conversation

the-ult
Copy link
Contributor

@the-ult the-ult commented Nov 23, 2021

  • Upgrade the project to NX 13.2 with Angular 13
  • Setup NX per project configuration
  • Update other dependencies
  • improve build targets and project tsconfig build settings

TODO (might need some help with these)

  • Properly setup build targets with @nrwl/angular:package and use tsconfig.lib.prod.json configuration for production
      "configurations": {
          "production": {
            "tsConfig": "projects/testing-library/tsconfig.lib.prod.json"
          },
          "development": {
            "tsConfig": "projects/testing-library/tsconfig.lib.json"
          }
        },
  • Breaking changes to README/Changelog?
  • Update Node version to LTS (16?) @timdeschryver it seems to be at 12 atm.

fixes: #258

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @the-ult, I will create a beta branch for this and change the target branch later this week. This way we can test it out, and add some more breaking changes before we release the new version.

  • "executor": "@nrwl/angular:package",: yes, you can update it
  • Should we update the peerDependencies to >= 13.0.0: yes
  • config tot Render for teardown: let's do this in another PR after this is merged
  • Breaking changes to README/Changelog?: these will be automatic 🙂

BREAKING CHANGE: Update peerDependencies to Angular 13
Use @nrwl/angular:package instead of
@angular-devkit/build-angular:ng-packagr
@timdeschryver timdeschryver changed the base branch from main to beta November 23, 2021 16:31
@timdeschryver timdeschryver merged commit b02ff76 into testing-library:beta Nov 23, 2021
@timdeschryver
Copy link
Member

Let's get this rolling! 🥳

@github-actions
Copy link

🎉 This PR is included in version 11.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@timdeschryver
Copy link
Member

@all-contributors please add @the-ult for maintenance

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @the-ult! 🎉

timdeschryver pushed a commit that referenced this pull request Dec 3, 2021
BREAKING CHANGE:

This version requires the following versions:

- Angular v13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade deps
2 participants