Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps #258

Closed
timdeschryver opened this issue Nov 3, 2021 · 5 comments · Fixed by #260
Closed

Upgrade deps #258

timdeschryver opened this issue Nov 3, 2021 · 5 comments · Fixed by #260

Comments

@timdeschryver
Copy link
Member

timdeschryver commented Nov 3, 2021

With the release of Angular we should also upgrade the deps in this lib:

  • Angular
  • NX
  • ???

This could also lead to a breaking change, and we can merge #257 with the release.

If someone wants to pick this up, feel free to add a comment.

@the-ult
Copy link
Contributor

the-ult commented Nov 4, 2021

As soon as NX releases the migration for Angular 13, I can create a PR.
So, probably next week

@the-ult
Copy link
Contributor

the-ult commented Nov 5, 2021

It is probably a good idea to see if Angular Testing Module teardown is properly handled atm.
And perhaps we can make it configurable or something. An extra option for Render?

see: https://dev.to/this-is-angular/improving-angular-tests-by-enabling-angular-testing-module-teardown-38kh

@timdeschryver
Copy link
Member Author

@the-ult +1 for adding the config option!
It should be handled correctly (#253), but it can't harm to double check.

@the-ult
Copy link
Contributor

the-ult commented Nov 23, 2021

Gonna try and create a PR this week

@github-actions
Copy link

🎉 This issue has been resolved in version 11.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants