Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more logs to bash script used for DockerHealthcheckWaitStratgyTest #2988

Merged
merged 4 commits into from
Aug 1, 2020
Merged

Add some more logs to bash script used for DockerHealthcheckWaitStratgyTest #2988

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
813c0bc
Add some more logs to bash script used for DockerHealthcheckWaitStrat…
kiview Jul 11, 2020
05c44fd
Remove echos and automatically log bash commands
kiview Jul 24, 2020
227b07b
Merge branch 'master' into healthcheck-debug
bsideup Jul 26, 2020
066caec
Merge branch 'master' into healthcheck-debug
rnorth Aug 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/test/resources/health-wait-strategy-dockerfile/write_file_and_loop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
#!/bin/ash

set -e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should do:

Suggested change
set -e
set -ex

so that the shell automatically logs the command that's about to be run.

We could actually just get rid of all the echos then...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added your suggestion accordingly.


echo sleeping
sleep 2
echo writing file
touch /testfile
echo wrote file

while true; do sleep 1; done