Add some more logs to bash script used for DockerHealthcheckWaitStratgyTest #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egyTest Echo once file has been written and make bash script fail on error.
rnorth
reviewed
Jul 12, 2020
| @@ -1,8 +1,11 @@ | |||
| #!/bin/ash | |||
|
|
|||
| set -e | |||
There was a problem hiding this comment.
Perhaps we should do:
Suggested change
| set -e | |
| set -ex |
so that the shell automatically logs the command that's about to be run.
We could actually just get rid of all the echos then...
There was a problem hiding this comment.
Good idea, added your suggestion accordingly.
rnorth
approved these changes
Jul 25, 2020
artjomka
pushed a commit
to artjomka/testcontainers-java
that referenced
this pull request
Aug 2, 2020
…gyTest (testcontainers#2988) Co-authored-by: Sergei Egorov <[email protected]> Co-authored-by: Richard North <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Echo once the file has been written and make bash script fail on error.
Might help is in identifying the reason for flaky test in case of
DockerHealthcheckWaitStratgyTest.startsOnceHealthy().