Pull image and accept registry out #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other than pulling an image to be sure that it exists this PR introduced a mechanism to download images from a private repository. Signed-off-by: Gianluca Arbezzano <[email protected]>
|
@gianarb Sorry for not getting back to you. This looks like a fine way to do it. Perhaps looking into https://github.com/docker/cli/blob/6686ada6a4cf4e872af4d9bf3f61c387be934d87/cli/config/credentials/credentials.go#L12 could be an idea if it's a valid use case to use the client's config/auth store from their Docker CLI (if available). |
|
Way better @sirlatrom do you have a chance to work on it? |
MeneDev
pushed a commit
to MeneDev/testcontainers-go
that referenced
this pull request
Aug 8, 2018
…nd-auth Pull image and accept registry out
mdelapenya
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Respect custom waitStrategy for InfluxDB (#1) fix(influxdb): Respect passed waitStrategy * Refactor test to use require for container state assertion Co-authored-by: Steven Hartland <[email protected]> * Change default wait strategy from checking logs to health check for influxdb2 (#2) * /health check waitStrategy for influx1 and influx2 * Undo health endpoint test after default strategy was changed * Update http health check to verify JSON status value (#3) * Move Shutdown check to WithInitDb (#4) Move Shutdown check to WithInitDb * Remove slice Co-authored-by: Steven Hartland <[email protected]> * Simplify comment Co-authored-by: Steven Hartland <[email protected]> * More precise WitInitDb domment --------- Co-authored-by: Steven Hartland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than pulling an image to be sure that it exists this PR introduced
a mechanism to download images from a private repository.
Fixed #2
@sirlatrom what do you think?
Signed-off-by: Gianluca Arbezzano [email protected]