Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Option to pull image if it does not exist on Docker host #2

Closed
sirlatrom opened this issue Jul 20, 2018 · 1 comment
Closed

Enhancement: Option to pull image if it does not exist on Docker host #2

sirlatrom opened this issue Jul 20, 2018 · 1 comment

Comments

@sirlatrom
Copy link
Contributor

Currently, the first example will fail if your Docker host does not have the nginx image pulled. Maybe a way to indicate the image should be pulled if it doesn't exist in the host could be useful?
@gianarb
Copy link
Member

gianarb commented Jul 24, 2018

I think it is! And we can make it the default behavior for sure.

@gianarb gianarb mentioned this issue Jul 24, 2018
Merged
@emetsger emetsger mentioned this issue May 19, 2024
Merged
mdelapenya pushed a commit that referenced this issue Nov 20, 2024
@marcinmilewski93 @stevenh
fix(influxdb): Respect custom waitStrategy (#2845)
83b47ca 
* Respect custom waitStrategy for InfluxDB (#1)

fix(influxdb): Respect passed waitStrategy

* Refactor test to use require for container state assertion

Co-authored-by: Steven Hartland <[email protected]>

* Change default wait strategy from checking logs to health check for influxdb2 (#2)

* /health check waitStrategy for influx1 and influx2

* Undo health endpoint test after default strategy was changed

* Update http health check to verify JSON status value (#3)

* Move Shutdown check to WithInitDb (#4)

Move Shutdown check to WithInitDb

* Remove slice

Co-authored-by: Steven Hartland <[email protected]>

* Simplify comment

Co-authored-by: Steven Hartland <[email protected]>

* More precise WitInitDb domment

---------

Co-authored-by: Steven Hartland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirlatrom @gianarb