Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add generate for mocks #2774

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Sep 8, 2024

Add generation for mocks, which can be run using make generate or go generate ./...

Correct output-format for golangci-lint as githubs-actions has been replaced by colored-line-numbers.

Add pre-commit target to help check code is valid before pushing.

Implements: #2765

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a58fe67
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66df16e3be34330008888a6e
😎 Deploy Preview https://deploy-preview-2774--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenh stevenh marked this pull request as ready for review September 9, 2024 08:48
@stevenh stevenh requested a review from a team as a code owner September 9, 2024 08:48
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment regarding checking if there are modified files on CI

.github/workflows/ci-test-go.yml Outdated Show resolved Hide resolved
@stevenh stevenh force-pushed the ci/mock-generation branch 2 times, most recently from 4adb9d0 to cc6689c Compare September 9, 2024 12:40
mdelapenya
mdelapenya previously approved these changes Sep 9, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Waiting for the CI to merge.

As a follow-up, we are going to replace the custom mocks from the wait strategies with this approach, right?

@mdelapenya mdelapenya self-assigned this Sep 9, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Sep 9, 2024
mdelapenya
mdelapenya previously approved these changes Sep 9, 2024
@stevenh stevenh marked this pull request as draft September 9, 2024 12:53
@stevenh
Copy link
Collaborator Author

stevenh commented Sep 9, 2024

LGTM, thanks!

Waiting for the CI to merge.

As a follow-up, we are going to replace the custom mocks from the wait strategies with this approach, right?

Yep already have some work in progress here

@stevenh stevenh force-pushed the ci/mock-generation branch 2 times, most recently from 59195ef to 03c7fa3 Compare September 9, 2024 14:40
@stevenh stevenh marked this pull request as ready for review September 9, 2024 15:38
@stevenh
Copy link
Collaborator Author

stevenh commented Sep 9, 2024

Unrelated failure, should be good now @mdelapenya.

Rebased to get the config fix to see if that completes all tests.

Add generation for mocks, which can be run using make generate or
go generate ./...

Correct output-format for golangci-lint as githubs-actions has been
replaced by colored-line-numbers.

Add pre-commit target to help check code is valid before pushing.

Ensure generate and mod tidy don't result in changes.

Run go mod tidy for all modules, some were out of date.

Implements: #2765
@mdelapenya mdelapenya merged commit b4f8294 into testcontainers:main Sep 9, 2024
112 checks passed
mdelapenya added a commit that referenced this pull request Sep 10, 2024
* main:
  ci: add generate for mocks (#2774)
  fix: docker config error handling when config file does not exist (#2772)
  docs: refine heading badges in README (#2770)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 11, 2024
* main:
  ci: add generate for mocks (testcontainers#2774)
  fix: docker config error handling when config file does not exist (testcontainers#2772)
  docs: refine heading badges in README (testcontainers#2770)
  feat(wait): for file (testcontainers#2731)
  feat(compose): select services via profiles (testcontainers#2758)
  chore(deps): bump mkdocs-markdownextradata-plugin from 0.2.5 to 0.2.6 (testcontainers#2761)
  fix: update template too (testcontainers#2763)
  chore(deps): bump actions/checkout from 4.1.1 to 4.1.7 (testcontainers#2762)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.2.2 (testcontainers#2760)
  fix: check if the discovered docker socket responds (testcontainers#2741)
  Upgrade milvus-io/milvus-sdk-go to avoid checksum mismatch. (testcontainers#2753)
  Fix trailing slash on Image Prefix (testcontainers#2747)
  chore: use new testcontainers/ryuk:0.9.0 image (testcontainers#2750)
@stevenh stevenh deleted the ci/mock-generation branch September 12, 2024 14:40
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 18, 2024
* main:
  fix: resource clean up for tests and examples (testcontainers#2738)
  ci: add generate for mocks (testcontainers#2774)
  fix: docker config error handling when config file does not exist (testcontainers#2772)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 23, 2024
* main:
  chore: use a much smaller image for testing (testcontainers#2795)
  fix: parallel containers clean race (testcontainers#2790)
  fix(registry): wait for (testcontainers#2793)
  fix: container timeout test (testcontainers#2792)
  docs: document redpanda options (testcontainers#2789)
  feat: support databend module (testcontainers#2779)
  chore: golangci-lint 1.61.0 (testcontainers#2787)
  fix(mssql): bump Docker image version (testcontainers#2786)
  fix: handle 127 error code for podman compatibility (testcontainers#2778)
  fix: do not override ImageBuildOptions.Labels when building from a Dockerfile (testcontainers#2775)
  feat(mongodb): Wait for mongodb module with a replicaset to finish (testcontainers#2777)
  fix(postgres): Apply default snapshot name if no name specified (testcontainers#2783)
  fix: resource clean up for tests and examples (testcontainers#2738)
  ci: add generate for mocks (testcontainers#2774)
  fix: docker config error handling when config file does not exist (testcontainers#2772)
mdelapenya added a commit that referenced this pull request Sep 26, 2024
* main: (29 commits)
  fix: template for code generation (#2800)
  fix: update module path (#2797)
  fix: container logging deadlocks (#2791)
  chore: use a much smaller image for testing (#2795)
  fix: parallel containers clean race (#2790)
  fix(registry): wait for (#2793)
  fix: container timeout test (#2792)
  docs: document redpanda options (#2789)
  feat: support databend module (#2779)
  chore: golangci-lint 1.61.0 (#2787)
  fix(mssql): bump Docker image version (#2786)
  fix: handle 127 error code for podman compatibility (#2778)
  fix: do not override ImageBuildOptions.Labels when building from a Dockerfile (#2775)
  feat(mongodb): Wait for mongodb module with a replicaset to finish (#2777)
  fix(postgres): Apply default snapshot name if no name specified (#2783)
  fix: resource clean up for tests and examples (#2738)
  ci: add generate for mocks (#2774)
  fix: docker config error handling when config file does not exist (#2772)
  docs: refine heading badges in README (#2770)
  feat(wait): for file (#2731)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants