[Enhancement]: replace manual mocks

[stevenh]

Proposal

Replace all manual mocks with generated ones, as started by #2731

[mdelapenya]

We must make sure there is a build command to do this 🙏

[stevenh]

We must make sure there is a build command to do this 🙏

I'd go one step further and ensure we validate they are up to date in CI.

My general preference is to have all of this handled by go generate thoughts?

[mdelapenya]

sure, the local build must do exactly the same as in the CI, so that developers can replicate what the CI does. So:

• adding a build command
• the CI uses a command to validate (simply checking the git state??), that can be used by developers to understand if they missed anything

[stevenh]

Yer this would be an example of github action to validate:

      - name: Install dependencies
        run: |
          go install github.com/vektra/mockery/[email protected]

      - name: Validate go mod / generate
        run: |
          go generate ./...
          go mod tidy
          git --no-pager diff && [[ 0 -eq $(git status --porcelain | wc -l) ]]

Updating locally would be:

go generate ./...

[mdelapenya]

Sounds good to me. I'm labelling this as a quick-win

[jasonyunicorn]

Has anyone stepped up to work on this? If not, I would like to volunteer as a first-time contributor to this repo!

[stevenh]

Yep I have some work in progress on this but ran into some additional inconsistencies. Need to get some time to split it out