turn off caching, even for bento boxes #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ moved the setting of the default values for cache_directory up to the default_config declaration section + added fast fail to `enable_cache?` for when a config declares the cache_directory to be false per the documentation + simplified the cache_directory getter to return the cache_directory only if `enable_cache?` criteria are met + some specs updated that expect to be caching, but did not meet `enable_cache?` criteria (using a bento) Signed-off-by: Robb Kidd <[email protected]>
robbkidd
force-pushed
the
robb/fix-turning-off-caching-with-bentos
branch
from
04f1f64 to
629691e
Compare
cheeseplus
approved these changes
Jul 24, 2017
thommay
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved the setting of the default values for cache_directory up to the
default_config declaration section
added fast fail to
enable_cache?for when a config declares thecache_directory to be false per the documentation
simplified the cache_directory getter to return the cache_directory
only if
enable_cache?criteria are metsome specs updated that expect to be caching, but did not meet
enable_cache?criteria (using a bento)Fixes #307