cache_directory: false doesn't disable the cache on bento boxes

[aespinosa]

Update: On test-kitchen 1.16.0 and kitchen-vagrant 1.1.0

Sample rspec test:

it 'does not set :synced_folders when cache_directory is false' do
  config[:box] = "bento/centos-99"
  config[:cache_directory] = false
  expect(driver[:synced_folders]).to eq([])
end

Test result:

Run options: include {:focus=>true}

Kitchen::Driver::Vagrant
  configuration
    does not set :synced_folders when cache_directory is false (FAILED - 1)

Failures:

  1) Kitchen::Driver::Vagrant configuration does not set :synced_folders when cache_directory is false
     Failure/Error: expect(driver[:synced_folders]).to eq([])
     
       expected: []
            got: [["/Users/aespinosa/.kitchen/cache", "/tmp/omnibus/cache", "create: true"]]
     
       (compared using ==)
     # ./spec/kitchen/driver/vagrant_spec.rb:351:in `block (3 levels) in <top (required)>'

Finished in 0.0184 seconds (files took 0.40801 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/kitchen/driver/vagrant_spec.rb:348 # Kitchen::Driver::Vagrant configuration does not set :synced_folders when cache_directory is false

I think this is breaking behavior for what is documented in https://github.com/test-kitchen/kitchen-vagrant#-cache_directory

[cheeseplus]

Do you mean 1.1.0? that seems a little too old.

[aespinosa]

Sorry i meant kitchen-vagrant 1.1.0 and test-kitchen 1.16.0 (the latest one). Updated the original description @cheeseplus