Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all Fog OpenStack options #98

Merged
merged 1 commit into from
Sep 21, 2015

Conversation

BobbyRyterski
Copy link
Contributor

This loads all the openstack options directly from Fog and calculates the optional settings so we don't have to chase OpenStack / Fog changes.

With fog 1.33.0, #optional_server_settings returns:

[
  :openstack_auth_token, :openstack_management_url, :openstack_service_type, 
  :openstack_service_name, :openstack_tenant, :openstack_tenant_id, 
  :openstack_identity_endpoint, :openstack_region, :openstack_endpoint_type, 
  :openstack_project_name, :openstack_project_id, :openstack_project_domain, 
  :openstack_user_domain, :openstack_domain_name, :openstack_project_domain_id, 
  :openstack_user_domain_id, :openstack_domain_id
]

I originally intended to only add the OpenStack identity v3 options, but I think this ended up as a neater solution.

]
expect(driver.send(:optional_server_settings)).to eq(expected)
expect(driver.send(:optional_server_settings)).not_to include(*excluded)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the best test, but too much else seemed like reimplementing the function.

@jjasghar jjasghar added the TODO label Sep 15, 2015
@jjasghar
Copy link
Contributor

Can you add something to the README.md about/possible options? Having support for this is awesome, but we need some words saying we have support too 😸

@@ -55,6 +55,9 @@ driver:
The `image_ref` and `flavor_ref` options can be specified as an exact id,
an exact name, or as a regular expression matching the name of the image or flavor.

All of Fog's `openstack` options (`openstack_domain_name`, `openstack_project_name`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this sound?

I would've liked to have a link to a definitive list of options, but I couldn't find one in the docs. We could link to the code, I guess.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is fine. People looking for the options'll know what to look for. Thanks!

@jjasghar
Copy link
Contributor

Cool, now I'd like another 👍 from someone other than you or me, and i can add this to the next release.

@jjasghar jjasghar added enhancement and removed TODO labels Sep 16, 2015
@david-crowder
Copy link

Not sure if this counts (@BobbyRyterski is a coworker), but I have tested this branch and everything works as expected. So while not an impartial 👍, I do support this change 😃

@BobbyRyterski
Copy link
Contributor Author

Sounds good, @jjasghar. I'll rebase now so it'll be all nice and neat.

jjasghar pushed a commit that referenced this pull request Sep 21, 2015
Support all Fog OpenStack options
@jjasghar jjasghar merged commit 5edcbf1 into test-kitchen:master Sep 21, 2015
@BobbyRyterski BobbyRyterski deleted the all_fog_options branch September 21, 2015 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants