-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all Fog OpenStack options #98
Conversation
] | ||
expect(driver.send(:optional_server_settings)).to eq(expected) | ||
expect(driver.send(:optional_server_settings)).not_to include(*excluded) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the best test, but too much else seemed like reimplementing the function.
Can you add something to the README.md about/possible options? Having support for this is awesome, but we need some words saying we have support too 😸 |
@@ -55,6 +55,9 @@ driver: | |||
The `image_ref` and `flavor_ref` options can be specified as an exact id, | |||
an exact name, or as a regular expression matching the name of the image or flavor. | |||
|
|||
All of Fog's `openstack` options (`openstack_domain_name`, `openstack_project_name`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's this sound?
I would've liked to have a link to a definitive list of options, but I couldn't find one in the docs. We could link to the code, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is fine. People looking for the options'll know what to look for. Thanks!
Cool, now I'd like another 👍 from someone other than you or me, and i can add this to the next release. |
Not sure if this counts (@BobbyRyterski is a coworker), but I have tested this branch and everything works as expected. So while not an impartial 👍, I do support this change 😃 |
Sounds good, @jjasghar. I'll rebase now so it'll be all nice and neat. |
0d58acc
to
562e684
Compare
Support all Fog OpenStack options
This loads all the
openstack
options directly from Fog and calculates the optional settings so we don't have to chase OpenStack / Fog changes.With fog 1.33.0,
#optional_server_settings
returns:I originally intended to only add the OpenStack identity v3 options, but I think this ended up as a neater solution.