-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all Fog OpenStack options #179
Conversation
This is similar to my pull request to kitchen-openstack. Since knife-openstack is a little more complex, this will probably need some work. |
We'll need some documentation on the README for the "sane" defaults for this change. I want to make sure something like this is as delightful as possible. |
I ran the specs against this and it blew up. I'll see if i can fix it, but some help on that would be appreciated. |
I've already dug into this a bit. The builds have been failing since 84f5a86 because the Rake task runs all tests ( Regardless, I was able to fix some of the functional tests by adding the ohai hint to # spec/functional/server_create_func_spec.rb:76
context 'for Linux' do
before do
@config = { openstack_floating_ip: '-1', bootstrap_ip_address: '75.101.253.10', ssh_password: 'password', hints: { "openstack" => {} }} The unit test failures cropped up in d120353. It looks like they're using the wrong expectation syntax. It should use # spec/unit/openstack_service_spec.rb:35
it 'sets the api_endpoint in auth params' do
expect(@instance.instance_variable_get(:@auth_params)[:openstack_auth_url]).to be_nil I can throw those fixes in this PR or make a new one. Do you have a preference? |
Yeah go ahead and add it to this PR. I'm cool with that. |
I'll wait for this to be merged then I'll release the gem. |
@@ -31,6 +31,14 @@ In order to communicate with an OpenStack API you will need to tell Knife your O | |||
knife[:openstack_tenant] = "Your OpenStack tenant name" | |||
knife[:openstack_region] = "Your OpenStack Region" | |||
|
|||
All of Fog's `openstack` options (`openstack_domain_name`, `openstack_project_name`, ...) are supported. This includes support for the OpenStack Identity v3 API: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjasghar, is this the kind of example you were looking for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this works!
Support all Fog OpenStack options
This loads all the
openstack
options directly from Fog to createauth_params
. The only deviations from Fog are the two that existed previously,openstack_insecure
andopenstack_password
.