-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables pushed app before starting #752
Conversation
@johnnyman727 How can I smoke test this update? Should I follow the steps here? Do you know why some of the |
@HipsterBrown that would be a good smoke test if you have a windows machine. Otherwise, I would just make sure The |
Ok thanks. I'll give that a shot when I get home tonight. It looks like #292 is nearly ready to be merged but if it still needs some time, it might be worth breaking out those mocks into a separate PR still so we can get this fix merged as well. That's up to you though. |
@HipsterBrown Okay, you'e sufficiently persuaded me to stop being lazy. I broke the unit test fix out into #754. |
As a matter of principle, this shouldn't land until the tests are green—we're all agreed on that, right? |
I've just given appveyor a kick to re-run those tests. |
@rwaldron how do you force AppVeyer to re-run the tests? |
b63ec46
to
55f66e0
Compare
All green tests means LGTM! 👍 |
There's a "re-build" button :) |
Fixes #707.
Travis will likely have issues with unrelated tests until #754 is merged.