Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new event function version #28

Conversation

taylorludwig
Copy link
Contributor

@taylorludwig taylorludwig commented Dec 13, 2019

Needs terraform-google-modules/terraform-google-event-function#38 to be released first.

Then source in main.tf should be updated.

google-event-function has been released

Once this is released we can use the functionality in a proper fix to terraform-google-modules/terraform-google-slo#7

@taylorludwig
Copy link
Contributor Author

google-event-function has been released to 1.2.0.

This PR has been updated and ready to go

@taylorludwig taylorludwig marked this pull request as ready for review December 17, 2019 22:05
Copy link
Contributor

@ocervell ocervell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much ! LGTM.
@morgante please merge and #26 and release a new version when you see this :)

@aaron-lane aaron-lane merged commit a82ec18 into terraform-google-modules:master Dec 18, 2019
@taylorludwig
Copy link
Contributor Author

No worries @ocervell, glad to help.
Thanks @aaron-lane for getting these released.

I've updated the slo module's pr to use the new released versions and tests are running now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants