-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/37 terraform created files in archive #38
Merged
aaron-lane
merged 10 commits into
terraform-google-modules:master
from
taylorludwig:feature/37-terraform-created-files-in-archive
Dec 17, 2019
Merged
Feature/37 terraform created files in archive #38
aaron-lane
merged 10 commits into
terraform-google-modules:master
from
taylorludwig:feature/37-terraform-created-files-in-archive
Dec 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@taylorludwig thank you so much for this and creating a PR in |
aaron-lane
suggested changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @taylorludwig!
Co-Authored-By: Aaron Lane <[email protected]>
aaron-lane
approved these changes
Dec 17, 2019
@taylorludwig thanks so much for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
Uses an approach similar to described in hashicorp/terraform-provider-archive#11
Adds a new optional input var
source_dependent_files
that can take a list oflocal_file
resources.This then forces the
archive
to not be created until all other terraform created files are in the source directory. Prior to this the archive would be created before any terraform createdlocal_file
s existed.With the extra
null_resource
andnull_data_source
workaround it allows terraform to converge (terraform plan/apply wont show changes unless there are actual file changes insource_directory
or terraform createdlocal_file
s). The comment above describes more why the workaround is needed.A new example and test is created to demonstrate this by simply having the function return back the value of the random created terraform file.
Once this is in we can go back and properly fix terraform-google-modules/terraform-google-slo#7