Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Terraform v0.12 #47

Merged
merged 23 commits into from
Jul 11, 2019
Merged

Add support for Terraform v0.12 #47

merged 23 commits into from
Jul 11, 2019

Conversation

aaron-lane
Copy link
Contributor

No description provided.

@aaron-lane aaron-lane added enhancement New feature or request blocked-0.12 labels Jun 14, 2019
@aaron-lane aaron-lane marked this pull request as ready for review July 4, 2019 21:10
Jberlinsky
Jberlinsky suggested changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@Jberlinsky Jberlinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! A couple documentation nit-picks.

README.md Outdated Show resolved Hide resolved
examples/simple_project_with_regional_network/versions.tf Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Jberlinsky Jberlinsky mentioned this pull request Jul 9, 2019
Merged
morgante and others added 2 commits July 9, 2019 15:10
@morgante
Merge pull request #53 from terraform-google-modules/internal/0.12-pa…
161b3e4 
…tch-level-version-pinning

Update README example to version-pin to patch version
@Jberlinsky
Update copyright notices to 2019
533c6ea
@Jberlinsky Jberlinsky mentioned this pull request Jul 9, 2019
Merged
@Jberlinsky Jberlinsky mentioned this pull request Jul 9, 2019
Merged
Jberlinsky and others added 3 commits July 9, 2019 17:24
@Jberlinsky
CI rebuild
33a4778
@Jberlinsky
CI rebuild
e44a573
@aaron-lane
Merge pull request #55 from terraform-google-modules/internal/0.12-up…
dcadfa6 
…date-README

Add a note about 0.11.x compatible version to README
@aaron-lane
Merge pull request #54 from terraform-google-modules/internal/update-…
39c91e7 
…copyright-to-2019

Update copyright notices to 2019
@aaron-lane aaron-lane requested a review from Jberlinsky July 10, 2019 20:12
@aaron-lane aaron-lane self-assigned this Jul 11, 2019
@aaron-lane aaron-lane merged commit 7ba1b23 into master Jul 11, 2019
@aaron-lane aaron-lane deleted the aaron-lane-0.12 branch July 11, 2019 18:31
aaron-lane added a commit that referenced this pull request Jul 12, 2019
@aaron-lane
Add #47, release date for 1.0.0 to CHANGELOG
4e7cd17
@ideasculptor ideasculptor mentioned this pull request Oct 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyk-code andreyk-code Awaiting requested review from andreyk-code

@morgante morgante Awaiting requested review from morgante

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees

@aaron-lane aaron-lane

Labels
blocked-0.12 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaron-lane @Jberlinsky @ivankorn @morgante