Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated to terraform 0.12 #48

Merged
merged 4 commits into from
Jun 18, 2019
Merged

Migrated to terraform 0.12 #48

merged 4 commits into from
Jun 18, 2019

Conversation

ivankorn
Copy link
Contributor

43: migrated to terraform 0.12

  • switched to docker image with terraform 0.12
  • migrated to new syntax
  • defined type for some variables
  • rewritten firewall's internal allow rules with dynamic block

@aaron-lane aaron-lane added the enhancement New feature or request label Jun 17, 2019
@aaron-lane
Copy link
Contributor

Fixes #43.

aaron-lane
aaron-lane suggested changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the remaining instances of unnecessary string interpolation from the code base.

@aaron-lane aaron-lane merged commit 1005760 into terraform-google-modules:aaron-lane-0.12 Jun 18, 2019
@skenmy skenmy mentioned this pull request Aug 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane aaron-lane approved these changes

@andreyk-code andreyk-code Awaiting requested review from andreyk-code

@morgante morgante Awaiting requested review from morgante

Assignees

@ivankorn ivankorn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivankorn @aaron-lane