Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for allowing internal firewall rules #123

Merged
merged 6 commits into from
Dec 11, 2019
Merged

Fix bug for allowing internal firewall rules #123

merged 6 commits into from
Dec 11, 2019

Conversation

SKozlovsky
Copy link
Contributor

@SKozlovsky SKozlovsky requested a review from a team December 5, 2019 19:45
@SKozlovsky SKozlovsky requested review from andreyk-code, Jeanno and a team as code owners December 6, 2019 10:53
aaron-lane
aaron-lane approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SKozlovsky!

@aaron-lane aaron-lane merged commit ca1bc01 into terraform-google-modules:master Dec 11, 2019
@morgante morgante changed the title Fix bug for firewall allow-internal rules Fix bug for allowing internal firewall rules Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane aaron-lane approved these changes

@andreyk-code andreyk-code Awaiting requested review from andreyk-code

@Jeanno Jeanno Awaiting requested review from Jeanno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in firewall module
2 participants
@SKozlovsky @aaron-lane