Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in firewall module #121

Closed
shashank-google opened this issue Dec 5, 2019 · 1 comment · Fixed by #123
Closed

Bug in firewall module #121

shashank-google opened this issue Dec 5, 2019 · 1 comment · Fixed by #123
Assignees
@SKozlovsky
Labels
bug Something isn't working P1 highest priority issues triaged Scoped and ready for work

Comments

@shashank-google
Copy link

Example: https://github.com/terraform-google-modules/terraform-google-network/tree/master/examples/submodule_firewall

Creates internal firewall rule (module.test-firewall-submodule.google_compute_firewall.allow-internal[0]) only with icmp. Will tcp, udp ingress rules are skipped. Can you please check ?
@aaron-lane aaron-lane added bug Something isn't working P1 highest priority issues labels Dec 5, 2019
@aaron-lane
Copy link
Contributor

@SKozlovsky please investigate this and provide a fix if it is reproducible.

@SKozlovsky SKozlovsky mentioned this issue Dec 5, 2019
Merged
@aaron-lane aaron-lane added the triaged Scoped and ready for work label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SKozlovsky SKozlovsky

Labels
bug Something isn't working P1 highest priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug for allowing internal firewall rules SKozlovsky/terraform-google-network
3 participants
@shashank-google @aaron-lane @SKozlovsky