-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support reservation affinity #2010
feat: support reservation affinity #2010
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @DrFaust92!
STDERR: Error: Incorrect attribute value type
on ../../../cluster.tf line 603, in resource "google_container_node_pool" "pools":
603: values = reservation_affinity.value.values
Inappropriate value for attribute "values": set of string required.
apeabody I think i fixed it given the limitation |
/gcbrun |
|
a69aced
to
7c5f1d8
Compare
/gcbrun |
7c5f1d8
to
8d5e4d7
Compare
/gcbrun |
apeabody can you share error? |
Of course:
|
15b76fa
to
5802685
Compare
9c40885
to
146ef14
Compare
apeabody I think this should work properly now, did some local testing on this |
/gcbrun |
146ef14
to
a1d17dc
Compare
/gcbrun |
1 similar comment
/gcbrun |
apeabody looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DrFaust92!
One comment on the documentation, otherwise I think this looks good to me.
113fb17
to
cc2ccf5
Compare
/gcbrun |
Closes #1990