Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reservation_affinity to node_pools config #1990

Closed
A-Bush opened this issue Jul 4, 2024 · 2 comments · Fixed by #2010
Closed

Add reservation_affinity to node_pools config #1990

A-Bush opened this issue Jul 4, 2024 · 2 comments · Fixed by #2010
Labels
enhancement New feature or request

Comments

@A-Bush
Copy link

A-Bush commented Jul 4, 2024

TL;DR

Add possibility to create nodepools from specific reservation

Terraform Resources

https://cloud.google.com/kubernetes-engine/docs/how-to/consuming-reservations#specific
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_reservation_affinity

Detailed design

Add possibility to request specific reservations in nodepools like Hashicorp Terraform provider for Google Cloud
  
  node_config {
    machine_type = "e2-medium"

    reservation_affinity {
      consume_reservation_type = "SPECIFIC_RESERVATION"
      key                      = "compute.googleapis.com/reservation-name"
      values                   = [google_compute_reservation.specific_reservation.name]
    }
  }


### Additional information

_No response_
@A-Bush A-Bush added the enhancement New feature or request label Jul 4, 2024
@song-william
Copy link

This would help our project as well! Our nodes require capacity reservations to be hit.

@DrFaust92
Copy link
Contributor

Ill try to take a look at this in the upcoming week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants