-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing README updates #191
Merged
morgante
merged 3 commits into
terraform-google-modules:master
from
chrislovecnm:readme-updates
Jun 26, 2019
Merged
Fixing README updates #191
morgante
merged 3 commits into
terraform-google-modules:master
from
chrislovecnm:readme-updates
Jun 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislovecnm
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
June 25, 2019 22:58
This is a new CI failure. |
chrislovecnm
pushed a commit
to chrislovecnm/terraform-google-kubernetes-engine
that referenced
this pull request
Jun 25, 2019
Adding PR terraform-google-modules#191 in a seperate commit which can be squashed or removed.
Sounds like an underlying API timeout/issue, not anything in Terraform.
*Morgante Pell*
Strategic Cloud Engineer
[email protected]
+1 212-565-7834
…On Tue, Jun 25, 2019 at 7:49 PM Chris Love ***@***.***> wrote:
* google_container_node_pool.pools: Error reading instance group manager returned as an instance group URL: "Get https://www.googleapis.com/compute/beta/projects/ci-kubernetes-engine/zones/us-east4-b/instanceGroupManagers/gke-stub-domains-clu-default-node-poo-7844eead-grp?alt=json&prettyPrint=false: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
This is a new one.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#191?email_source=notifications&email_token=AAMNNGJKU6EKVL2U4SNQ3S3P4KVHBA5CNFSM4H3M7F22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYR46DQ#issuecomment-505663246>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMNNGIYRT5LJ63JBMTVXLTP4KVHBANCNFSM4H3M7F2Q>
.
|
chrislovecnm
force-pushed
the
readme-updates
branch
from
June 26, 2019 15:54
62385b8
to
0d48173
Compare
@aaron-lane / @morgante PTAL |
morgante
suggested changes
Jun 26, 2019
I did not make the README change in the autogen directory. Fixing that.
chrislovecnm
force-pushed
the
readme-updates
branch
from
June 26, 2019 15:59
0d48173
to
336e3ec
Compare
@morgante PTAL |
morgante
approved these changes
Jun 26, 2019
morgante
approved these changes
Jun 26, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…dme-updates Fixing README updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not make the README change in the autogen directory. Fixing that.
FIXES: #190