Enabling two features in beta clusters

[chrislovecnm]

This allows pod security policies and binary authorization to be used
by both beta private and beta public clusters. Previously these two features
where limited to only private clusters, and this commit also removes
that functionality from private clusters.

[aaron-lane]

@chrislovecnm I believe the reason why those features were only added to the private cluster was because they require the beta provider. Fortunately, the template logic has been updated to account for beta clusters!

[aaron-lane]

Please run make generate_docs to regenerate the tables after make generate regenerates the modules.

[chrislovecnm]

Done

[chrislovecnm]

I will update. Thanks for the review

[chrislovecnm]

@aaron-lane @morgante PTAL - I updated the PR title and body to reflect the changes.

[morgante]

Please run make generate_docs, otherwise LGTM.

[chrislovecnm]

#191 needs to be merged. I forgot that the README.md lives in the autogen directory as well.

[chrislovecnm]

Updated with generate_docs.

@morgante / @aaron-lane I added 13bf6dd which can be dropped before merging. This is the same as changes as #191. This should allow this PR to pass CI now.

[chrislovecnm]

 * module.example.module.gke.local.cluster_type_output_pod_security_policy_enabled: local.cluster_type_output_pod_security_policy_enabled: Resource 'google_container_cluster.zonal_primary' does not have attribute 'pod_security_policy_config.0.enabled' for variable 'google_container_cluster.zonal_primary.*.pod_security_policy_config.0.enabled'

Not a guru in terraform, so I am not quite sure where this is coming from. pod_security_policy_config is in a beta module, so it should not even impact this cluster. Looking into this

[chrislovecnm]

Please do not merge, I am working on what I think are some bugs.

[chrislovecnm]

@morgante @aaron-lane the latest bug I am trying to figure out is:

* module.gke.local.cluster_type_output_binary_authorization_enabled: local.cluster_type_output_binary_authorization_enabled: Resource 'google_container_cluster.primary' does not have attribute 'enable_binary_authorization.0.enabled' for variable 'google_container_cluster.primary.*.enable_binary_authorization.0.enabled'

I am confused a bit as I have defined enable_binary_authorization in the main.tf file

  cluster_type_output_binary_authorization_enabled = {
    regional = "${element(concat(google_container_cluster.primary.*.enable_binary_authorization.0.enabled, list("")), 0)}"
    zonal    = "${element(concat(google_container_cluster.zonal_primary.*.enable_binary_authorization.0.enabled, list("")), 0)}"
  }

and then

  cluster_binary_authorization_enabled = "${local.cluster_type_output_binary_authorization_enabled[local.cluster_type] ? true : false}"

[chrislovecnm]

So I cannot get the output to work, but really I do not care at this point. If we want to add the output for binary authorization later we can.

[chrislovecnm]

@morgante @aaron-lane we are missing a bunch of other beta features. Do you want another PR or just to update this one? For example enable_tpu, vertical_pod_autoscaling, etc.

[aaron-lane]

@chrislovecnm let's handle the additional features in different pull requests to minimize the amount of content to review per branch.

[morgante]

So I cannot get the output to work, but really I do not care at this point. If we want to add the output for binary authorization later we can.

Yeah, that's fine. Go ahead and drop it.

[itlinux]

Hello guys, I have the following output "instance_id" { value = "${lookup(var.google_compute_instance.default, count.index)}" } resource "google_compute_instance" "default" { count = "${var.number_of_vms}" name = "remo-${count.index + 1}-${random_id.instance_id.hex}” $ terraform validate Error: Reference to undeclared input variable on main.tf line 42, in output "instance_id": 42: value = "${lookup(var.google_compute_instance.default, count.index)}" An input variable with the name "google_compute_instance" has not been declared. This variable can be declared with a variable "google_compute_instance" {} block. Error: Reference to "count" in non-counted context on main.tf line 42, in output "instance_id": 42: value = "${lookup(var.google_compute_instance.default, count.index)}" The "count" object can be used only in "resource" and "data" blocks, and only when the "count" argument is set. Any tips will be great. Thanks

[chrislovecnm]

@itlinux please file your question on an issue https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/new

[chrislovecnm]

@morgante @aaron-lane PTAL ... CI is passing

[morgante]

@chrislovecnm Thanks for the contribution.