Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource mounting problems on resource that supports tags #169

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

eerkunt
Copy link
Member

@eerkunt eerkunt commented Oct 29, 2019

As also reported in #168, a problem exists where resource mounting and recursive searching were causing a problem on resources that support tags where we should not either do recursive searching or resource mounting.

This PR will disable resource mounting on scenarios where resources that support tags are used.

@eerkunt eerkunt added the bug label Oct 29, 2019
@eerkunt eerkunt added this to the 1.0.52 milestone Oct 29, 2019
@eerkunt eerkunt self-assigned this Oct 29, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 621

  • 32 of 35 (91.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 78.366%

Changes Missing Coverage Covered Lines Changed/Added Lines %
terraform_compliance/common/helper.py 10 11 90.91%
terraform_compliance/extensions/terraform.py 19 21 90.48%
Totals Coverage Status
Change from base Build 619: 0.3%
Covered Lines: 710
Relevant Lines: 906

💛 - Coveralls

@eerkunt eerkunt merged commit 0616ee4 into master Oct 29, 2019
@eerkunt eerkunt deleted the fix/issue-168 branch October 29, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants