-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource being ignored by tests #168
Comments
I'm going to assume "Many missing resources requires tagging." (from the Essentially you've not covered all resources yet? :-) |
Thanks for reporting this @mrcrilly 🎉 All resources that support tags (according to the utilised terraform provider) will be recognised by This is quite a standard test that has been used by many, interestingly failing for you. Debugging. |
Found the problem, it is due to resource mounting capability of Unfortunately, this makes the test pass while it is expected to be failed. Will find a good structure to fix this problem and release the new version. Thanks again! |
1.0.52 has been released for fixing this issue. Would it be possible to have a quick re-test with the new version ? By the way, I highly recommend to upgrade your Python environment, since 2.7 will be obsolete soon and is not supported by |
Hi @mrcrilly, Did you find any time to re-test your problem with the latest version ? |
Assuming the problem has been resolved, closing the issue. Please do not hesitate to open a new one if the problem still continue. Thanks 🎉 |
Description :
I am adding an
aws_subnet
to my Terraform code base without tags, producing a plan file that includes the new resource (which has no tags), and then passing this toterraform-compliance
, which is not applying the followScenario Outline
to the new resource:To Reproduce
terraform-compliance -f compliance/ -p plan.out
pip
)tags.feature
...Expected behavior :
I expect the tests to fail given
aws_subnet.test
does not have any tags defined. It is a resource that can be given tags. MyScenario Outline
checks for all resources that support tags and tests them for a minimal set. Myaws_subnet.test
resource is not being included.I would expect the tests to fail when attempting to add a new resource that does not comply with the requirements defined.
Tested versions :
The text was updated successfully, but these errors were encountered: