Use false instead of 0 in enable_create_db_option_group flag

[robinbowes]

Description

I see this error when passing "var.create_db_option_group" as false:

Error: module.db_worker_replica.local.enable_create_db_option_group: local.enable_create_db_option_group: __builtin_StringToInt: strconv.ParseInt: parsing "false": invalid syntax in:

${var.option_group_name == "" && var.engine != "postgres" ? var.create_db_option_group : 0}

This PR seems to fix it.

Edit: Further investigation suggests that the problem occurs when create_db_option_group is passed in as a string, eg:

locals {
  some_flag = "${some_condition ? true : false}"
}

module "db" {
  source  = "terraform-aws-modules/rds/aws"
  version = "1.28.0"
  create_db_option_group    = "${local.some_flag}"
  # rest of params
}

A workaround is to pass in 1/0 instead of "true"/"false":

  create_db_option_group    = "${local.some_flag ? 1 : 0}"

[antonbabenko]

Thanks Robin!

v1.29.0 has been released.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.