Use boolean value in condition #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of an integer value makes Terraform to force the casting of the
other value so that both match the same type.
If the `create_db_option_group` or `create_db_subnet_group` parameters
is set as the result of a conditional expression :
```hcl
create_db_option_group = "${var.enable ? true : false}"
create_db_subnet_group = "${var.enable ? true : false}"
```
then TF fails because of this casting :
```
* local.enable_create_db_subnet_group: local.enable_create_db_subnet_group: __builtin_StringToInt: strconv.ParseInt: parsing "false": invalid syntax in:
${var.db_subnet_group_name == "" ? var.create_db_subnet_group : 0}
* local.enable_create_db_subnet_group: local.enable_create_db_subnet_group: __builtin_StringToInt: strconv.ParseInt: parsing "false": invalid syntax in:
${var.db_subnet_group_name == "" ? var.create_db_subnet_group : 0}
* local.enable_create_db_option_group: local.enable_create_db_option_group: __builtin_StringToInt: strconv.ParseInt: parsing "false": invalid syntax in:
${var.option_group_name == "" && var.engine != "postgres" ? var.create_db_option_group : 0}
* local.enable_create_db_option_group: local.enable_create_db_option_group: __builtin_StringToInt: strconv.ParseInt: parsing "false": invalid syntax in:
${var.option_group_name == "" && var.engine != "postgres" ? var.create_db_option_group : 0}
```
|
This is now fixed in v2.0.0 which works with Terraform 0.12. |
dud225
added a commit
to dud225/terraform-aws-rds
that referenced
this pull request
Jul 16, 2019
This PR is a follow-up of PR terraform-aws-modules#118. This is the exact same changeset than terraform-aws-modules#137 but for the `create_db_subnet_group` variable.
antonbabenko
pushed a commit
that referenced
this pull request
Jul 17, 2019
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of an integer value makes Terraform to force the casting of the
other value so that both match the same type.
If the
create_db_option_grouporcreate_db_subnet_groupparametersis set as the result of a conditional expression :
then TF fails because of this casting :