Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove incorrect AutoScaling Group resource ARNs for CloudWatch event rule #1854

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • remove incorrect resource ARNs for cloudwatch event rule; event rule is matched on aws.ec2 and not aws.autoscaling so the autoscaling ARNs in the resources block is incorrect

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • N/A

@antonbabenko antonbabenko changed the title chore: Remove incorrect AutoScaling Group resource ARNs for CloudWatch event rule fix: Remove incorrect AutoScaling Group resource ARNs for CloudWatch event rule Feb 8, 2022
@antonbabenko antonbabenko merged commit 0784180 into terraform-aws-modules:master Feb 8, 2022
@bryantbiggs bryantbiggs deleted the chore/example-update branch February 8, 2022 19:26
@antonbabenko
Copy link
Member

This PR is included in version 18.5.1 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove spot-termination event rule code, because of it doesn't work properly.
2 participants