Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spot-termination event rule code, because of it doesn't work properly. #1850

Closed
sepiro2000 opened this issue Feb 7, 2022 · 2 comments · Fixed by #1854
Closed

Remove spot-termination event rule code, because of it doesn't work properly. #1850

sepiro2000 opened this issue Feb 7, 2022 · 2 comments · Fixed by #1854

Comments

@sepiro2000
Copy link

Description

aws.ec2 event source doesn't have an ARN of ASG, so https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/irsa_autoscale_refresh/charts.tf#L273 code doesn't work properly. As mentioned in https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-instance-termination-notices.html aws.ec2 event source has an ARN of ec2.

⚠️ Note

Before you submit an issue, please perform the following first:

  1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
  2. Re-initialize the project root to pull down modules: terraform init
  3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

  • Terraform:
  • Provider(s):
  • Module:

Reproduction

Code Snippet to Reproduce

Expected behavior

Actual behavior

Terminal Output Screenshot(s)

Additional context

I think remove spot-termination event rule code, because of it doesn't work properly.

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.5.1 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants