Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update syntax for Terraform 0.15 #1260

Closed
wants to merge 1 commit into from
Closed

Conversation

antonbabenko
Copy link
Member

No description provided.

@antonbabenko antonbabenko requested a review from barryib March 1, 2021 15:20
@antonbabenko
Copy link
Member Author

@barryib I have added a couple of fixes related to Terraform 0.15 syntax while making these kinds of changes in other repositories, and wonder if you also want to use the same flow with GH Actions developed by @bryantbiggs ? We are using it since last week on most of others repositories (for example, https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/master/.github/workflows/pre-commit.yml).

It would be very nice for us to use the same process across all repos in this organization. Bryant's solution allows to have multiple versions for examples, modules, root dir and terraform_validate will be executed for the lowest supported version, while the complete set of pre-commit hooks is executed with the maximum supported version of Terraform.

@TjeuKayim
Copy link
Contributor

This seems to be a partial duplicate of my pull request #1165 that replaces the use of deprecated functions list() and map() with the new syntax.

@antonbabenko
Copy link
Member Author

@TjeuKayim I see it now, I will be able to rebase this one after yours is merged.

@mbevc1
Copy link

mbevc1 commented Apr 14, 2021

0.15 was released today 🥳
Could we get those PRs merged?

@antonbabenko
Copy link
Member Author

For the Terraform 0.15 users v15.1.0 has been just released.

@antonbabenko antonbabenko deleted the tf015-syntax branch April 16, 2021 10:44
@mbevc1
Copy link

mbevc1 commented Apr 16, 2021

Cheers @antonbabenko 🎉 . Any reason it was just tagged and not released?

@antonbabenko
Copy link
Member Author

antonbabenko commented Apr 16, 2021

Very good question! I was not entirely sure about the release process for this module and followed the process I have for all other terraform-aws-modules.

We will have to ask @barryib to make a release the way he does it normally.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants